[WIP] Simplify Connect Auth Response #951
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: dae5575 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
TBDocs Report ✅ No errors or warnings @web5/api
@web5/crypto
@web5/crypto-aws-kms
@web5/dids
@web5/credentials
TBDocs Report Updated at 2024-10-14T18:57:53Z |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #951 +/- ##
=======================================
Coverage 93.34% 93.34%
=======================================
Files 118 118
Lines 33660 33673 +13
Branches 2728 2730 +2
=======================================
+ Hits 31419 31432 +13
Misses 2200 2200
Partials 41 41
|
LiranCohen
changed the title
LiranCohen
requested review from
csuwildcat,
shamilovtim,
thehenrytsai and
nitro-neal
as code owners
LiranCohen
force-pushed
the
lirancohen/process-permissions-request
branch
from
3b9e435 to
afc0c2a
Compare
LiranCohen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pulls the portion from
submitAuthResponsethat creates the authorization grants out into it's own functioncreateAuthResponseGrants.Additionally, the creation of the JWK is pulled out of the
submitAuthResponsemethod. So a response for the OIDC flow now looks like this:There is further optimization that could be done as well as the clean-up of failed grant authorizations, but I will leave that for after the extended OIDC flow is merged in to avoid too much change.